Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIP-65: rename "Relay List Metadata" to "Outbox model" #1459

Closed
wants to merge 1 commit into from

Conversation

AsaiToshiya
Copy link
Collaborator

The "Outbox model" is familiar to many nostriches. And for beginners who don't know this NIP, there is no significant difference between the names "Outbox model" and the "Relay List Metadata".

@vitorpamplona
Copy link
Collaborator

LGTM

@kehiy
Copy link
Contributor

kehiy commented Aug 30, 2024

@AsaiToshiya Why do we have to rename it while the Relay List Metadata is a more self-describing name?

I think we can choose a better name as well which is more self-describing. So users can find out what is it about. or new devs.

One example: Preferred Relay List

@AsaiToshiya
Copy link
Collaborator Author

No one calls NIP-65 "Relay List Metadata". A commonly recognized name is more important than a self-describing name. Besides, either way, the name doesn't tell everything.

@kehiy
Copy link
Contributor

kehiy commented Aug 30, 2024

No one means the current users and developers on the nostr. but what about someone new who checks these NIPs or see this names in clients and docs???

@AsaiToshiya
Copy link
Collaborator Author

Will someone new not read the document? No, I think they will read it if they are interested.

@pablof7z
Copy link
Member

NACK

Outbox model and NIP-65 are not the same thing; NIP-65 is a tool, among multiple others (like relay/pubkey hints) that inform the outbox model.

@erskingardner
Copy link
Contributor

I agree on the NACK. Shouldn't change.

@dluvian
Copy link
Contributor

dluvian commented Aug 30, 2024

What about something like "In- and Outbox Relay List" ?

The word "Outbox model" is being used a lot but people can't find anything about it in this repo. So I agree that we should rename this nip to something that includes "Outbox", as it is the main tool for implementing the outbox model.

@monlovesmango
Copy link
Member

NACK for me too.

A commonly recognized name is more important than a self-describing name.

I dunno. kind 0 is called user metadata but colloquially its referred to as the user profile, but I guess you might feel that this should also be renamed.

Besides, either way, the name doesn't tell everything.

sure, but imo "Relay List Metadata" tells more than "Outbox Model".

@mikedilger
Copy link
Contributor

I'm also NACK.

I think it is fine as is. I get the point though. If we wanted these titles to be ELI5 we could just call this "How a user declares which relays they use, and therefore where you can find them" or for short "User Relay List". The term "Metadata" was added to the original title "Relay List" as a compromise for people who wanted to put this data into kind-0, but it just makes the title more confusing IMHO. Outbox model is a common phrase but doesn't describe what the hell it is.

So my preference is "User Relay List" or just "Relay List" or just keep "Relay List Metadata". Or something like that.

@melvincarvalho
Copy link

NACK Outbox is not quite the same things as a Relay List. Outbox needs a lot of testing to even see if it is going to be the optimal model. Relay Lists are future proofed because we will always need lists of relays. Furthermore, relay lists are in documentation and code in dozens or places, and would require many pull requests to rebrand, which is a pain.

@fabianfabian
Copy link

fabianfabian commented Aug 31, 2024

I prefer "User Relay List" too, or "User Preferred Relay List". Metadata is the confusing part, I consider metadata created_at/pubkey/kind etc.

@staab
Copy link
Member

staab commented Aug 31, 2024

I agree metadata is a stupid word. I do think outbox is equivalent to NIP 65, general relay selection being a broader problem, so the change is semantically fine in my book. But I don't feel strongly either way. Closing, since consensus is clearly to keep this as is.

@staab staab closed this Aug 31, 2024
@AsaiToshiya
Copy link
Collaborator Author

OK. Alright, thanks everyone for the discussion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.